Custom Thread Groups - "Same user on each iteration" support for JMeter 5.2 onwards #690
Conversation
plugins/casutg/src/main/java/com/blazemeter/jmeter/threads/AdditionalFieldsPanel.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/main/java/com/blazemeter/jmeter/threads/AdditionalFieldsPanel.java
Show resolved
Hide resolved
plugins/casutg/src/main/java/com/blazemeter/jmeter/threads/arrivals/ArrivalsThreadGroup.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/test/java/kg/apc/jmeter/threads/AbstractSimpleThreadGroupImpl.java
Outdated
Show resolved
Hide resolved
.../casutg/src/test/java/com/blazemeter/jmeter/threads/arrivals/ArrivalsThreadGroupGuiTest.java
Outdated
Show resolved
Hide resolved
...s/casutg/src/main/java/com/blazemeter/jmeter/threads/concurrency/ConcurrencyThreadGroup.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/main/java/kg/apc/jmeter/threads/SteppingThreadGroup.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/main/java/kg/apc/jmeter/threads/UltimateThreadGroup.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/test/java/com/blazemeter/jmeter/control/VirtualUserControllerTest.java
Outdated
Show resolved
Hide resolved
.../casutg/src/test/java/com/blazemeter/jmeter/threads/arrivals/ArrivalsThreadGroupGuiTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/blazemeter/jmeter/threads/arrivals/FreeFormArrivalsThreadGroupGuiTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/blazemeter/jmeter/threads/arrivals/FreeFormArrivalsThreadStarterTest.java
Outdated
Show resolved
Hide resolved
...sutg/src/test/java/com/blazemeter/jmeter/threads/concurrency/ConcurrencyThreadGroupTest.java
Outdated
Show resolved
Hide resolved
...tg/src/test/java/com/blazemeter/jmeter/threads/concurrency/ConcurrencyThreadStarterTest.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/test/java/kg/apc/jmeter/threads/AbstractSimpleThreadGroupImpl.java
Outdated
Show resolved
Hide resolved
plugins/casutg/src/test/java/kg/apc/jmeter/threads/AbstractSimpleThreadGroupImpl.java
Outdated
Show resolved
Hide resolved
|
Thanks @undera for all the help You are very quick at reviewing. I saw all the "Unwanted changes" with the commit of the requested changes. The PR is much smaller. Thank you very much for the suggestions and for allowing the emulator to be updated. As you may have noticed I uploaded a version of the emulator. I noticed most of the plugins are at 0.2 so it will only be known if it affects or not if they are updated to 0.5. |
|
Looks good now, thank you very much |
|
Thanks @undera I will proceed with the plugin descriptor as soon as the plugin is available. Thanks. |
|
OOps. I did not see your message when merged. |
|
@undera Don't worry. As soon as I can, I'll create the update for the descriptors. We'll get in sync with the next PR of the plugin release. Thank you very much. |
…er 5.2 onwards (undera#690) * Upgrade to JMeter 5.2 and add "Same user on each iteration" support * Revert name and description change * Ad Workaround for new JMeters * Fix ss.prop path on saveservice_properties and upgrade_properties * Use new jmeter-plugins-emulators 0.5 and remove WA * Move addNewThread to parent Abstract * Fix text case * Set default value for "Same User On Each Iteration" * Clean code * Clean code for more "Unwanted changes"
Custom Thread Groups - "Same user on each iteration" support for JMeter 5.2 onwards
In 2019, support for the concept of "Same user on each iteration" was added to JMeter 5.2.
The "Thread Groups" of the "Custom Thread Groups" plugin need to support this concept.
The proposal to support it is to raise the minimum supported version to JMeter to 5.2 and change the plugin to add the support and change version to 3.0 (because no longer support JMeter prior to 5.2).
Unfortunately, when the functionality was implemented in JMeter 5.2, it was done through a modification in its JMeterThread constructor and a private internal flag, which brings difficulties for its support from the current JMeter 2.13 support (and probably could not be solved by reflection even if it were attempted using that method)
According to the statistics provided by jmeter-plugins, more than 80% of the active JMeter are equal to or higher than JMeter 5.2 (released at the end of 2019, more than 5 years ago).
In case users want to use the plugin in versions prior to JMeter 5.2, they must use the previous version 2.10.
I hope that this PR proposal is welcomed to begin updating the support for new JMeters.
PS: I tried to modify as little as possible to make the review as easy as possible.
I also discovered a bug in jmeter-plugins-emulators regarding how it assigns the properties of where the save services file is located, which caused the ss.props file to not be found in new jmeters. The WA solve that problem.