function initialize changes for language switcher, modal, accordian, biocard and modal #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying design-system with
|
| Latest commit: |
9ec1954
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7dfedffd.design-system.pages.dev |
| Branch Preview URL: | https://1499-optimize-js-loading.design-system.pages.dev |
…1499-optimize-js-loading
…sign-system into 1499-optimize-js-loading
…tialization for tab, PageHero, Carousels and gallery
Jura
reviewed
Mar 5, 2025
| @@ -9,7 +9,7 @@ export const Accordion = ({ headerText, descriptionText }) => { | |||
| // }, []); | |||
|
|
|||
| return ( | |||
| <ul className="accordion" aria-label="accordion" data-component="accordion"> | |||
| <ul className="accordion" aria-label="accordion" data-undps-component="accordion"> | |||
There was a problem hiding this comment.
@mihir880 , it has to be data-undpds- prefix (as in UNDP Design System) so it will be mnemonic
Jura
reviewed
Mar 5, 2025
stories/assets/js/init-loader.js
Outdated
| if (typeof window.UNDP?.langSwitch === 'function') { | ||
| window.UNDP.langSwitch(); | ||
| } else { | ||
| // if (typeof window.UNDP?.langSwitch === 'function') { |
There was a problem hiding this comment.
@mihir880 , your original idea was great - to check if the module is already loaded and use it that way, opting for load dynamically only if the function is not present. I'd rather keep it that way to make script more versatile. The only issue you have to resolve is changing window.UNDP.functionName in the condition to simply functionName as it is defined in the global scope if loaded as a separate script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.