Skip to content

Revert "Add comparison of test results across platforms and ICU versions" #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Add comparison of test results across platforms and ICU versions" #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
281 changes: 0 additions & 281 deletions verifier/compare_template.html
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions verifier/compare_template.py
View file
Open in desktop

This file was deleted.

24 changes: 3 additions & 21 deletions verifier/summary_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,19 +239,8 @@
let background_color;
for (const test_type of test_types) {
tr = table.insertRow();

test_type_td = tr.insertCell();

// Create a link to the page to compare
const a_ref = document.createElement('a');
const link = document.createTextNode('Compare ' + test_type);
a_ref.title = "Compare " + test_type;
test_type.innerHTML = test_type;
// Assemble the data for the instances
let compare_list = [];
let test_names = [];

<!-- put link to comparison selection for the test type -->
td = tr.insertCell();
td.innerHTML = test_type

const tests = exec_summary_json[test_type];
for (const exec of executed_platforms) {
Expand Down Expand Up @@ -318,7 +307,6 @@
details.push(link);
}
}

td = tr.insertCell();
if (reports.length > 0) {
// Create the data for the reports
Expand Down Expand Up @@ -356,13 +344,7 @@
}
td = tr.insertCell();
td.innerHTML = details.join('');
}
// Set the compare link for this test type.
const compare_link_text = "compare_" + test_type + ".html";
test_type_td.innerHTML = "<a href=\'" + compare_link_text + "'" +
" target='_blank'>" + test_type + "</a>";


}
}
}
</script>
Expand Down
Loading
Loading