-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22714 fix zos build, use OpenXL #3008
base: main
Are you sure you want to change the base?
Conversation
6697a6b
to
c68ce7f
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
423a492
to
f4050de
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
lots of good deletion here! For the BOMs, would it make sense just to fix them up with a build step? |
OpenXL is basically clang, that allowed me to get rid of many "OS390 only" code and tricks. Actually i have found one bug in OpenXL v2.1, it fails to generate correct name for sidedeck if output path is relative and library name has no suffix, for output library path like: I have added BOM fix in build time generated index files, also made sure those generated as UTF-8. But regarding this files: |
Hello @markusicu @srl295 what is missing for this PR to be merged? |
@markusicu LGTM ready to merge? |
Hello @markusicu , can we merge this? is anything missing? |
I have fixed the git clone of this repo on zos and moved build from old XLc compiler to new OpenXL compiler.
More details https://unicode-org.atlassian.net/browse/ICU-22714
As of now:
icu4c/source/data/misc/currencyNumericCodes.txt
icu4c/source/data/misc/icustd.txt
icu4c/source/data/misc/zoneinfo64.txt
Checklist