Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22812 copy shared data from CLDR to top level testdata #3053

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ICU-22812 copy shared data from CLDR to top level testdata #3053

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jun 28, 2024 •
edited
Loading

  • draft, wip
Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22812
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@srl295 srl295 self-assigned this Jun 28, 2024
@srl295 srl295 mentioned this pull request Jul 31, 2024
Merged
7 tasks
srl295
srl295 commented Aug 7, 2024
View reviewed changes
tools/cldr/build.xml
@@ -68,6 +78,7 @@
<target name="clean-cldr-testdata" depends="init-args">
<delete dir="${testDataDir4C}"/>
<delete dir="${testDataDir4J}"/>
<delete dir="${testDataDirBoth}"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right, as there are additional tests NOT in CLDR that ICU has.

@echeran echeran self-requested a review August 7, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeran echeran Awaiting requested review from echeran

At least 1 approving review is required to merge this pull request.

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srl295