-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22723 RC API change reports for C/J #3211
ICU-22723 RC API change reports for C/J #3211
Conversation
@@ -23,11 +23,49 @@ Removed from ICU 75 | |||
|
|||
| File | API | ICU 75 | ICU 76 | | |||
|---|---|---|---| | |||
| messageformat2_data_model.h | Builder& icu::message2::MFDataModel::Builder::addUnsupportedStatement(UnsupportedStatement&&, UErrorCode&) | InternalICU 75 | (missing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catamorphism @mihnita @echeran There are a lot of MF2 changes here, and below for Java -- both compared with what the API change report showed just a couple of weeks ago. Are these all covered by API proposals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API changes should always be proposed via icu-design email and a section in the API proposal doc.
Even for tech preview, it doesn't make sense to publicly propose the initial API and then silently change parts of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
7ada9e4
to
d7939a0
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
I looked what happened with the previous MF2 Design docs. The first one is here: https://docs.google.com/document/d/1NkHwFRWV9MiQROq4VVBh21tRMrP2DxpODg3fjHh0-Jw/edit#heading=h.rjgzrdwrcuur It is called
The next iteration is here: https://docs.google.com/document/d/1CzzbO5Es-OVMG6OnOMOgJwyU0zn8VlD_LJX3i9kMsuA/edit?resourcekey=0-CLzUfOMJA01jv16aEDj65w#heading=h.gf8wdfvznnx3
And there is only a very high level outline of the data model listing the public classes / interfaces. The current iteration is 100% identical to that one, except that it removes 3 entries:
Other than the data model, I checked all classes, and the only differences are the 3 methods above, and the addition of error handling methods ( I can put together a summary for this release that is very similar to the "second iteration" document before
Should I do a 75.1 => 76.1 summary? |
Thanks Mihai for checking! |
Checklist