Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scx data #6044

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update scx data #6044

wants to merge 1 commit into from

Conversation

Manishearth
Copy link
Member

Fixes #6041

Needs unicode-org/icu#3355 and the data from it to land

@Manishearth Manishearth requested a review from sffc January 28, 2025 19:26
@Manishearth
Copy link
Member Author

Confirmed that this passes the following test:

#[test]
fn expected_script_thing() {
    use crate::props::Script;
    use crate::script::ScriptWithExtensions;
    let scripts = ScriptWithExtensions::new()
        .get_script_extensions_val('\u{2bc}')
        .iter()
        .collect::<Vec<_>>();
    assert_eq!(
        scripts,
        [
            Script::Bengali,
            Script::Cyrillic,
            Script::Devanagari,
            Script::Latin,
            Script::Thai,
            Script::Lisu,
            Script::Toto
        ]
    );
}

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0-beta1 script properties not up to date for unicode 16
2 participants