Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Ethiopian eras with CLDR #6246

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Align Ethiopian eras with CLDR #6246

merged 6 commits into from
Mar 6, 2025

Conversation

robertbastian
Copy link
Member

We currently use a pre-incar era, which is not defined in CLDR. Instead, we should use the mundi era before the incar era.

@robertbastian robertbastian requested a review from a team as a code owner March 6, 2025 15:26
Manishearth
Manishearth previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, feel free to fix extendedYear issue here or separately

Manishearth
Manishearth previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct

@Manishearth
Copy link
Member

We might need ctors from extended_year for temporal

@anba
Copy link

anba commented Mar 6, 2025

FWIW: Contrary to CLDR, it also seems possible not to switch to the mundi era before the incarnation. See tc39/proposal-temporal#2900 (comment) and tc39/proposal-temporal#2900 (comment) for examples from am.wikipedia.org which uses CE/BCE-style year counting.

@robertbastian robertbastian reopened this Mar 6, 2025
Manishearth
Manishearth previously approved these changes Mar 6, 2025
View reviewed changes
@robertbastian robertbastian merged commit 54f680a into unicode-org:main Mar 6, 2025
28 checks passed
@robertbastian robertbastian deleted the ethiopian branch March 6, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@sffc sffc Awaiting requested review from sffc sffc is a code owner

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @Manishearth @anba