Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transliteration test_katakana_hiragana #6259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add transliteration test_katakana_hiragana #6259

wants to merge 1 commit into from
+8 −0

Conversation

sffc
Copy link
Member

@sffc sffc commented Mar 9, 2025

@sffc sffc requested a review from a team as a code owner March 9, 2025 04:27
@sffc sffc mentioned this pull request Mar 9, 2025
Open
@robertbastian
Copy link
Member

I don't think this necessarily needs to be merged, it doesn't exercise any code paths that are untested otherwise, and it's potentially brittle under CLDR updates. It demonstrates to Frank how to load this transliterator, and has fulfilled its purpose already.

@sffc
Copy link
Member Author

sffc commented Mar 10, 2025

Yeah I'll wait for feedback from @FrankYFTang on whether this works for their use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @robertbastian @Manishearth