Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Any-Lower and Any-Upper transliterators #6260

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian marked this pull request as ready for review March 9, 2025 22:01
@robertbastian robertbastian requested review from sffc, Manishearth and a team as code owners March 9, 2025 22:01
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't quite understand the data pipeline here, and this is cleaner than I expected.

What's the behavior of Any-Title after this?

Comment on lines -89 to -97
|locale| {
if locale.normalizing_eq("und-t-und-x0-lower") {
Some(Ok(Box::new(LowercaseTransliterator(
CaseMapperBorrowed::new(),
))))
} else {
None
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: Might be good to retain an example doing this override behavior somewhere, if there isn't already one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still tested here

@robertbastian
Copy link
Member Author

What's the behavior of Any-Title after this?

Same as Any-BreakInternal, it will produce a warning during compilation and compile to x-any-title (for which the user could provide a runtime override). Datagen skips transliterators that use Any-Title.

@robertbastian robertbastian merged commit 3917808 into unicode-org:main Mar 10, 2025
28 checks passed
@robertbastian robertbastian deleted the case branch March 10, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants