Add more docs to js-tiny Makefile #7255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Nov 21, 2025
| # Build the WASM library. Explanation of the flags: | ||
| # -Cpanic=abort: removes unwind machinery | ||
| # -Copt-level=s: tells llvm to optimize for size | ||
| # -C link-arg=-zstack-size=${WASM_STACK_SIZE}: the default is too large and contributes to high runtime memory |
Member
There was a problem hiding this comment.
nit: this is because of compiler bugs, no? 100k is a pretty large stack size, I think we set it to be larger than the default
Member
robertbastian
left a comment
robertbastian
left a comment
There was a problem hiding this comment.
the main JS Makefile is in ffi/npm. please add the explanations there and then call out how this file differs (basically the custom linker script)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7251