bugfix/1835: Keep nulls in polars when dropping invalid rows and nullable=True #1890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nullable=True in polars, it seems the
check_outputs
values from the error handler are left asnull
rather thanTrue
where values are null. This would be one possible way to remedy that to match with pandas behavior as per #1835 however I am not sure if this is the best place to handle that behavior, or even if it makes sense to match pandas behavior here or not.There also seemed to be a bug in the original test for polars dropping null values which I attempted to fix up here.