Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add field types for ExtensionDtype #1929

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

mauro-dribia
Copy link
Contributor

Issue: #1928

@cosmicBboy
Copy link
Collaborator

cosmicBboy commented Mar 5, 2025

@mauro-dribia can we add a unit for this? You can basically work off of the code snippet you posted #1928 and move it into a unit test function

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (812b2a8) to head (fcf97f8).
Report is 202 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1929      +/-   ##
==========================================
- Coverage   94.28%   93.49%   -0.79%     
==========================================
  Files          91      121      +30     
  Lines        7013     9380    +2367     
==========================================
+ Hits         6612     8770    +2158     
- Misses        401      610     +209     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mauro-dribia
Copy link
Contributor Author

@mauro-dribia can we add a unit for this? You can basically work off of the code snippet you posted #1928 and move it into a unit test function

sure! I just pushed a unit test

@cosmicBboy
Copy link
Collaborator

thanks @mauro-dribia, and congrats on your first PR to pandera! 🚀

@cosmicBboy cosmicBboy merged commit 66564af into unionai-oss:main Mar 6, 2025
173 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants