Merge pull request #4529 from unisonweb/runarorama/fixNatToHex

Fix bug in `Bytes.fromBase16` when chunks have an odd size
unisonweb · Dec 21, 2023 · 8e12c77 · 8e12c77
2 parents 5e98e80 + a14d683
commit 8e12c77
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/lib/unison-util-bytes/src/Unison/Util/Bytes.hs b/lib/unison-util-bytes/src/Unison/Util/Bytes.hs
@@ -370,13 +370,7 @@ arrayToChunk bs = case BA.convert bs :: Block Word8 of
 chunkFromArray = arrayToChunk
 
 fromBase16 :: Bytes -> Either Text.Text Bytes
-fromBase16 bs = case traverse convert (chunks bs) of
-  Left e -> Left (Text.pack e)
-  Right bs -> Right (fromChunks bs)
-  where
-    convert b =
-      BE.convertFromBase BE.Base16 (chunkToArray @BA.Bytes b)
-        <&> arrayToChunk @BA.Bytes
+fromBase16 = fromBase BE.Base16
 
 toBase32, toBase64, toBase64UrlUnpadded :: Bytes -> Bytes
 toBase32 = toBase BE.Base32