bugfix: fix suffixification of indirect dependencies #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes the original issue that I reported for this! |
aryairani
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5374
This PR fixes a bug in suffixification of indirect dependencies. The bug was caused by the unnecessary-but-harmless optimization to the stopping condition of suffixification (
Set.size matchingRefs == 1), which has been around forever, and which suddenly became necessary-not-to-do-and-decidedly-harmful-if-done after suffixification was amended to prefer direct deps to indirect deps in #5338. The fix was simply to delete that optimization.Test coverage
I've added a transcript (failing in the first commit) that demonstrates the fix.