-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for observables in LRE executors #2681
base: main
Are you sure you want to change the base?
Adding support for observables in LRE executors #2681
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 93 93
Lines 4223 4223
=======================================
Hits 4167 4167
Misses 56 56 ☔ View full report in Codecov by Sentry. |
Hi! I tried adding the test for a batched executor as well but could not prepare an I was trying something like this:
You can find the The problem is that I was unable to formulate a |
If you check test_executor.py you can see a lot of examples of executors. I would recommend using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shivansh20128 Let me know if you have any more questions about the batched executors with observables. Hopefully, the test_exectuor.py examples are helpful.
"degree, fold_multiplier, observable", | ||
[(2, 2, obs_z), (2, 3, obs_y), (3, 4, obs_x)], | ||
) | ||
def test_lre_executor_with_observables(degree, fold_multiplier, observable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be the exact same as test_lre_exp_value_with_observable
. I would recommend moving the assert lines to that test and removing this one.
This PR aims to add support for observables in the LRE executors.
#Resolves #2513
Description
License
Before opening the PR, please ensure you have completed the following where appropriate.