-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aquapointer blog post #528
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c85fa99
to
fa97915
Compare
This reverts commit bad1204. Fix file structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Misty-W. This is great. Potentially, I have some change requests and suggestions, but I want to check with you how much time sensitive this is. We could merge as it is this now and then improve the text even when is live (without yet publicizing it). Or we could do all at once later as in usual PR review.
About the feedback: The text is great and crisp, but it goes down to the very technical part very quickly, especially given the high interdisciplinary type of the work. I'd make more specific suggestions about this first part, including for visuals.
Thanks @nathanshammah! Definitely welcome your comments. There's not a big rush but targeting to wrap up the "Phase 1" items of the project this month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Misty-W I added more detailed comments and suggestions.
@Misty-W thanks for the edits. When you can, there are some comments to address, on the first part of the blog post: a more gentle introduction and explanation (QUBO, the high level rationale, etc.), as well as an image (or more) such as those used by Mauro. |
@Misty-W here is the blog post by QP. Please consider adding reference to the paper just published – with a format from references, see, e.g., the collisions post markdown. It would be great to post it soon as we have also other posts in the pipeline but it's good to keep it FIFO as much as possible. |
To do: add references 2 and 3, image(s), markdown formatting. |
@nathanshammah thanks for the suggestions! I think I addressed all of your comments. Let me know if there's any other changes needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now, great intro! Some comments:
- Please double check with authors of the images for eventual credits.
- Reference image one and whether the second panel is the actual 3DRISM image
- Regarding the second image, it needs more explanation. It does not explain the meaning of crosses, circles, or the equation. You can consider removing part of the image if it is too cumbersome to explain, but right now it is a bit too much left to the reader to figure out.
- "3D Reference Interactive Site Model (3D-RISM)" what about making it a reference as the other ones, instead of a direct link, since it's a paper?
Hi @Misty-W, checking for any updates here. |
hi @nathanshammah, I reached out to Mauro and Daniele for the image permissions / credit and am awaiting their response. I believe everything else is addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, great. Approved modulo the credits, feel free to merge once they're in.
Adds a blog post re-introducing Aquapointer and outlining the latest updates.