Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquapointer blog post #528

Merged
merged 18 commits into from
Oct 18, 2024
Merged

Aquapointer blog post #528

merged 18 commits into from
Oct 18, 2024

Conversation

Misty-W
Copy link
Contributor

@Misty-W Misty-W commented Sep 5, 2024

Adds a blog post re-introducing Aquapointer and outlining the latest updates.

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unitary-fund ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 1:14am
unitary-fund-prel ✅ Ready (Inspect) Visit Preview Oct 18, 2024 1:14am

This reverts commit bad1204.

Fix file structure
Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Misty-W. This is great. Potentially, I have some change requests and suggestions, but I want to check with you how much time sensitive this is. We could merge as it is this now and then improve the text even when is live (without yet publicizing it). Or we could do all at once later as in usual PR review.

About the feedback: The text is great and crisp, but it goes down to the very technical part very quickly, especially given the high interdisciplinary type of the work. I'd make more specific suggestions about this first part, including for visuals.

@Misty-W
Copy link
Contributor Author

Misty-W commented Sep 13, 2024

Thanks @nathanshammah! Definitely welcome your comments. There's not a big rush but targeting to wrap up the "Phase 1" items of the project this month.

Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Misty-W I added more detailed comments and suggestions.

src/content/blog/2024_09_aquapointer.md Outdated Show resolved Hide resolved
src/content/blog/2024_09_aquapointer.md Outdated Show resolved Hide resolved
src/content/blog/2024_09_aquapointer.md Outdated Show resolved Hide resolved
src/content/blog/2024_09_aquapointer.md Outdated Show resolved Hide resolved
src/content/blog/2024_09_aquapointer.md Outdated Show resolved Hide resolved
@nathanshammah
Copy link
Member

@Misty-W thanks for the edits. When you can, there are some comments to address, on the first part of the blog post: a more gentle introduction and explanation (QUBO, the high level rationale, etc.), as well as an image (or more) such as those used by Mauro.

@nathanshammah
Copy link
Member

nathanshammah commented Oct 7, 2024

@Misty-W here is the blog post by QP. Please consider adding reference to the paper just published – with a format from references, see, e.g., the collisions post markdown. It would be great to post it soon as we have also other posts in the pipeline but it's good to keep it FIFO as much as possible.

@Misty-W
Copy link
Contributor Author

Misty-W commented Oct 9, 2024

To do: add references 2 and 3, image(s), markdown formatting.

@Misty-W
Copy link
Contributor Author

Misty-W commented Oct 9, 2024

@nathanshammah thanks for the suggestions! I think I addressed all of your comments. Let me know if there's any other changes needed.

Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now, great intro! Some comments:

  • Please double check with authors of the images for eventual credits.
  • Reference image one and whether the second panel is the actual 3DRISM image
  • Regarding the second image, it needs more explanation. It does not explain the meaning of crosses, circles, or the equation. You can consider removing part of the image if it is too cumbersome to explain, but right now it is a bit too much left to the reader to figure out.
  • "3D Reference Interactive Site Model (3D-RISM)" what about making it a reference as the other ones, instead of a direct link, since it's a paper?

@nathanshammah
Copy link
Member

Hi @Misty-W, checking for any updates here.

@Misty-W
Copy link
Contributor Author

Misty-W commented Oct 16, 2024

hi @nathanshammah, I reached out to Mauro and Daniele for the image permissions / credit and am awaiting their response. I believe everything else is addressed.

Copy link
Member

@nathanshammah nathanshammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, great. Approved modulo the credits, feel free to merge once they're in.

@Misty-W Misty-W merged commit a0f6f89 into main Oct 18, 2024
1 check passed
@Misty-W Misty-W deleted the mw-aquapointer-blog branch October 18, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants