Unitsml schema template using Lutaml::Xsd and Metanorma command #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added complex_type and attribute_groups templates and added simple_type as partial
4 tasks
|
@suleman-uzair thanks! Please remove document.html from the latest commit since we shouldn't keep artifacts in the repo. Also, the document.adoc requires some metadata, please copy the structure from say, sources/unitsdb/document.adoc. Thanks! |
ronaldtse
requested changes
Aug 22, 2025
| <xsd:attributeGroup name="{{attribute_group.name}}"> | ||
| {%- assign element_order = attribute_group | resolved_element_order: %} | ||
| {%- for element in element_order %} | ||
| {%- assign attribute_drop = element | class_name_end_with: "::AttributeDrop" -%} |
There was a problem hiding this comment.
We don't want any "Ruby class names" in Liquid... The attribute variable here should already be the Drop object. Every XSD element should be here as a Drop object.
| {%- assign attribute_group_drop = element | class_name_end_with: "::AttributeGroupDrop" -%} | ||
| {%- assign simple_type = element.simple_type %} | ||
| {%- if attribute_drop %} | ||
| <xsd:attribute{{ element | attributes_xml_representation_for: }}{% unless simple_type %}/{% endunless %}> |
There was a problem hiding this comment.
Do we have to handcraft XML elements here? We actually want the source directly, which should be provided by the drop (add a "source" method?).
You can see how Expressir stores the source of the parsed content and provides it through the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
adocandliquidfiles for Unitsml schema documentation generation viaLutaml::Xsdgem.closes #5