refactor!: fully migrate to fetch api using srvx #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fully migrates h3 to be based on Web APIs (Request => Response).
Node.js and other platform compatibilities will be completely handled by lightweight srvx.
New
app.serveAPI is exposed to easily start server (it is smart about platform running from using export conditions!)Some optimizations for Node.js fast paths are removed (which should be investigated later). Stream errors also need to be better handled in Node.js (srvx issue likely)
afterResponsehook support is removed since with web APIs, there is no after return (it is up to platform to handle response)