Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set delimiter to ; in windows #176

Merged
merged 7 commits into from
Dec 30, 2024
Merged

feat!: set delimiter to ; in windows #176

merged 7 commits into from
Dec 30, 2024

Conversation

malezjaa
Copy link
Contributor

Reference: #175

This pull request fixes the issue where the delimiter is a colon (:) on all platforms, including Windows where it should use a semicolon (;).

src/path.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: delimiter based on the platform fix!: set delimiter to ; on windows Dec 30, 2024
@pi0 pi0 changed the title fix!: set delimiter to ; on windows fix!: set delimiter to ; in windows Dec 30, 2024
@pi0 pi0 changed the title fix!: set delimiter to ; in windows feat!: set delimiter to ; in windows Dec 30, 2024
@pi0 pi0 merged commit 43241f6 into unjs:main Dec 30, 2024
1 check passed
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (bdab761) to head (c4ae1ed).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   99.45%   99.31%   -0.14%     
==========================================
  Files           4        4              
  Lines         364      293      -71     
  Branches      114      120       +6     
==========================================
- Hits          362      291      -71     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants