Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix layouting on mobile #18261

Draft
wants to merge 107 commits into
base: master
Choose a base branch
from
Draft

fix: Fix layouting on mobile #18261

wants to merge 107 commits into from
+3,129 −5,465

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 20, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #15981, closes #13400

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Sep 20, 2024
@Youssef1313 Youssef1313 mentioned this pull request Sep 20, 2024
Closed
6 tasks
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

This was referenced Sep 21, 2024
Open
Open
Open
Open
Open
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

Youssef1313 and others added 26 commits November 9, 2024 11:49
@Youssef1313
chore: Attempt to stabilize iOS layouting
bc58c9a
@Youssef1313
chore: Fix build
afcd381
@Youssef1313
chore: Fix build after rebase
f4f233f
@Youssef1313
chore: Remove workaround that's now causing issues
c76e702
@Youssef1313
chore: Revert
43d704b
@Youssef1313
Revert "chore: Remove workaround that's now causing issues"
0b2e73a 
This reverts commit 81ea2eb.
@Youssef1313
chore: Adjust workaround
e145b0a
@Youssef1313
chore: Adjust
1ca6519
@Youssef1313
chore: Progress
ed13646
@Youssef1313
chore: Adjust for mobile
f200254
@Youssef1313
chore: Adjust
81940fa
@Youssef1313
chore: Progress
0288cc1
@Youssef1313
chore: Fix build
0a28a13
@Youssef1313
chore: Fix imagebrush
56d5c0f
@Youssef1313
chore: Fix build
82f866a
@Youssef1313
chore: Fix unit test build
f2bddb7
@Youssef1313
chore: Adjust for FlipView
0fd1178
@Youssef1313
chore: Try to fix flipview....
f830077
@Youssef1313
chore: Few adjustments
e599cf4
@Youssef1313
chore: Adjust few tests
5df6b1b
@Youssef1313
chore: Adjust test
9c640ee
@Youssef1313
chore: Adjust
c63ff74
@Youssef1313
chore: Measure when Frame is set
c801d6d
@Youssef1313
chore: temp
3a13279
@Youssef1313
chore: Set Frame
bfd3f63
@MartinZikmund @Youssef1313
chore: Adjust for macOS
f7d69df
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18261/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18261/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinZikmund MartinZikmund

@Xiaoy312 Xiaoy312

@Youssef1313 Youssef1313

Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure area/code-generation Categorizes an issue or PR as relevant to code generation platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Milestone
No milestone
4 participants
@Youssef1313 @unodevops @MartinZikmund @Xiaoy312