fix(wasm): key tracking when no one is subscribing to Key<Down|Up> #18702
Conversation
|
This affects NavigationView (as reported in the original issue) because, for some reason, NavigationView's logic is written so that if any modifiers are pressed, it should not open the picker popup. |
ramezgerges
force-pushed
the
wasm_modifier_key_tracking
branch
from
f2f751b
to
542a226
Compare
| #if __WASM__ | ||
| #pragma warning disable IDE0051 // Remove unused private members | ||
| [JSExport] | ||
| private static void UpdateKeyStateNative(string key, bool down) |
There was a problem hiding this comment.
Can you add a manual test that explains what to test? Thanks!
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18702/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18702/index.html |
There was a problem hiding this comment.
We will need to improve keyboard state tracking in general as it is not completely reliable, e.g. when key is pressed before the window gets focused, opened #18714 to track this.
|
@MartinZikmund Actually, this is still the case on WASM after this PR. This only fixes missing tracking updates when KeyDown/Up has no listeners, but an out-of-focus press will still mess up the tracking. We will need to investigate that separately. |
github-actions
bot
added
the
area/automation
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18702/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18702/index.html |
GitHub Issue (If applicable): closes #18617
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):