Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled menu in VS - Remove to not be visible. (backport #18736) #18744

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 8, 2024

GitHub Issue (If applicable): Closes license 373

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When the UnoMenuCommand are Dispose, we disable and hidden the Uno Platform Menu.

To repro.

I was able to reproduce this,
when i am running the project using a version that enable the Extension Menu.
And than rebase to the same project using a different sdk
and without the HR trigger to enable the Extension. (the UnoMenuCommand are diposed)

image

and When returned to the branch with the HR feature that add the Extension menu, the menu was enabled again.

image

What is the new behavior?

Now we are removing the Menu from the CommandService.
When the UnoMenuCommand started again the Main Menu will be created again.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):


This is an automatic backport of pull request #18736 done by [Mergify](https://mergify.com).

@jeromelaban jeromelaban merged commit f40ad16 into release/stable/5.5 Nov 8, 2024
11 of 17 checks passed
@jeromelaban jeromelaban deleted the mergify/bp/release/stable/5.5/pr-18736 branch November 8, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants