Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoid duplicated logs and prevent error bubbling (backport #18746) #18756

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 9, 2024

Chore

Avoid duplicated logs and prevent error bubbling

What is the current behavior?

  • Errors might logged twice
  • Once logged, error are re-thrown driving to unknown behavior

What is the new behavior?

  • Errors logged only once
  • Once logged, errors are discarded

PR Checklist

Please check if your PR fulfills the following requirements:


This is an automatic backport of pull request #18746 done by [Mergify](https://mergify.com).

(cherry picked from commit 9e38c7a)

# Conflicts:
#	src/Uno.UI.RemoteControl.VS/EntryPoint.cs
@mergify mergify bot added the conflicts label Nov 9, 2024
Copy link
Contributor Author

mergify bot commented Nov 9, 2024

Cherry-pick of 9e38c7a has failed:

On branch mergify/bp/release/stable/5.5/pr-18746
Your branch is up to date with 'origin/release/stable/5.5'.

You are currently cherry-picking commit 9e38c7a321.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/Uno.UI.RemoteControl.VS/EntryPoint.cs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18756/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18756/index.html

@jeromelaban
Copy link
Member

Kept for the next release.

@jeromelaban jeromelaban closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants