Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Map Key.KP_Enter to VirtualKey.Enter #6426

Merged
merged 1 commit into from
Jul 11, 2021
Merged

feat: Map Key.KP_Enter to VirtualKey.Enter #6426

merged 1 commit into from
Jul 11, 2021

Conversation

lukeblevins
Copy link
Contributor

GitHub Issue (If applicable): #5000

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Enter key on number pads isn't mapped to VirtualKey.Enter

What is the new behavior?

Map the key in hopes it fixes the issue.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

I have no way to verify whether this fixes the reported issue or not.

Internal Issue (If applicable): N/A

@lukeblevins lukeblevins requested a review from a team July 8, 2021 12:57
@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2021

@lukeblevins
Copy link
Contributor Author

@jeromelaban I'm also about to test this so we know whether or not to close the associated issue. 🙂

@lukeblevins
Copy link
Contributor Author

@jeromelaban Can confirm this PR fixes the issue as VirtualKey.Enter is now detected.
image

@lukeblevins lukeblevins linked an issue Jul 11, 2021 that may be closed by this pull request
24 tasks
@jeromelaban jeromelaban merged commit 831f8bb into unoplatform:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Skia][Gtk] Number Keypad Enter key is not mapped properly
3 participants