-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for handle only interaction #71
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: cf2f01e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @adamtrll ! Seems like there's much more to DrawerHandle
, do you mind help adding the similar feature as the one in vaul's DrawerHandle?
Thanks for the review! I'll take a closer look and try to add any missing parts. |
Hi @zernonia. I implemented all the features the original handle has, including the test view for the playground. I couldn’t figure out where the handle styles in the original playground were coming from, so I included them in a scoped style tag. The only functional change I made is how handle clicks behave when the drawer is at the last snap point and not dismissible. The original playground "works" for two full cycles before it stops responding for handle clicks, which didn't seem intentional. This minor change ensures that clicking the handle at the last snap point returns it to the first snap point, and it can be found at the very end of function handleCycleSnapPoints() {
// ...
const nextSnapPointIndex = isLastSnapPoint ? 0 : currentSnapIndex + 1
activeSnapPoint.value = snapPoints.value[nextSnapPointIndex]
} |
Closes: #68
Add new DrawerHandle component and handleOnly boolean prop to DrawerHandleRoot to limit drawer interactions to the handle.