Skip to content

refactor: remove unnecessary network stack reload in ConnectSettingsService #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove unnecessary network stack reload in ConnectSettingsService #1751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/unraid-api-plugin-connect/src/unraid-connect/connect-settings.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export class ConnectSettingsService {
this.configService.set('connect.config.wanport', input.port);
// when forwarding with upnp, the upnp service will clear & set the wanport as necessary
}

this.configService.set('connect.config.wanaccess', wanaccessEnabled);
// do the wanaccess port-override last; it should have the highest precedence
if (!wanaccessEnabled) {
Expand All @@ -244,7 +244,6 @@ export class ConnectSettingsService {
},
});

await this.networkService.reloadNetworkStack();
return true;
Comment on lines 244 to 247
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regresses network reload when remote access update fails

After updateRemoteAccess updates the config it now immediately returns, relying on DynamicRemoteAccessService.enableDynamicRemoteAccess to emit events that reload nginx/DNS. That service swallows exceptions and may return early without emitting the ENABLE_WAN_ACCESS/DISABLE_WAN_ACCESS events (e.g. UpnpRemoteAccessService.stop() throws before the event is emitted). Prior to this change the method unconditionally awaited networkService.reloadNetworkStack(), ensuring the new connect.config.wanaccess value was applied even when the dynamic service failed. With the fallback removed, disabling WAN access can silently leave the previous nginx configuration active until another component triggers a reload, keeping WAN access exposed longer than intended.

Useful? React with 👍 / 👎.

}

Expand Down
Loading