-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user-shares.md #225
Conversation
Trying to make minimum free space more clear
WalkthroughThe pull request involves updating the documentation for Unraid OS, specifically the section on user shares and minimum free space. The change provides a more detailed explanation of how Unraid handles file storage requests when the minimum free space setting is applied, clarifying the disk selection process during file transfers to prevent disk full errors. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/unraid-os/manual/shares/user-shares.md (1)
53-53
: LGTM! Consider minor grammatical improvements.The added explanation significantly improves clarity regarding minimum free space requirements. Consider these minor grammatical improvements:
-When Unraid receives a request to store a file, say for example `file.eg`, it has no idea how big the file is. Unraid will pick a spot to place it and begin to store the file data as the data is transferred over the network. Now, this may result in Unraid picking a storage disk with insufficient storage space for the complete file. Unraid is unaware there isn't enough space when it first places the file so it will only find out when the disk is full. +When Unraid receives a request to store a file, say for example `file.eg`, it has no idea how big the file is. Unraid will pick a spot to place it and begin to store the file data as the data is transferred over the network. Now, this may result in Unraid picking a storage disk with insufficient storage space for the complete file. Unraid is unaware there isn't enough space when it first places the file, so it will only find out when the disk is full.🧰 Tools
🪛 LanguageTool
[uncategorized] ~53-~53: A comma might be missing here.
Context: ...t enough space when it first places the file so it will only find out when the disk ...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/manual/shares/user-shares.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/unraid-os/manual/shares/user-shares.md
[uncategorized] ~53-~53: A comma might be missing here.
Context: ...t enough space when it first places the file so it will only find out when the disk ...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: AWS Amplify Console Web Preview
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Trying to make minimum free space more clear
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit