Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwrapped old generate #1784

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix unwrapped old generate #1784

wants to merge 8 commits into from

Conversation

NinoRisteski
Copy link
Contributor

is this a fix for: #1723 ?

Changes

  • Added try-except block around delattr call for _unwrapped_old_generate
  • Safely handles the case when the attribute doesn't exist
  • Maintains all existing functionality while preventing AttributeError

@danielhanchen
Copy link
Contributor

I'm actually confused why del does not work

@NinoRisteski
Copy link
Contributor Author

I'm actually confused why del does not work

Oh ok. Will work on it

@danielhanchen
Copy link
Contributor

Oh it's not your fault! I'm confused why Python errors out when using del

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NinoRisteski @danielhanchen