Don't update unchanged dom attributes

unyt-org · Feb 13, 2025 · 3893e2b · 3893e2b
1 parent 1104149
commit 3893e2b
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/datex-bindings/dom-utils.ts b/datex-bindings/dom-utils.ts
@@ -787,9 +787,16 @@ export class DOMUtils {
 
         // normal attribute
         else {
-            if (val === false) element.removeAttribute(attr);
-            else if (val === true) element.setAttribute(attr, "");
-            else element.setAttribute(attr, this.formatAttributeValue(val, root_path, element));
+            if (val === false) {
+                if (element.hasAttribute(attr)) element.removeAttribute(attr);
+            }
+            else if (val === true) {
+                if (!element.hasAttribute(attr)) element.setAttribute(attr, "");
+            }
+            else {
+                const newValue = this.formatAttributeValue(val, root_path, element);
+                if (element.getAttribute(attr) !== newValue) element.setAttribute(attr, newValue);
+            }
         }