Skip to content

Create documentation for Sandbox Mocked Withdrawals #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoelGama
Copy link

@JoelGama JoelGama commented Apr 17, 2025

Create documentation for Sandbox Mocked Withdrawals

CRY-5199

@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 11:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for Sandbox Mocked Withdrawals, explaining the purpose, supported networks, configuration, and code examples to simulate withdrawal flows.

  • Added an overview and rationale for using mocked withdrawals.
  • Detailed configuration and example usage, including code snippets in JSON and TypeScript.
Comments suppressed due to low confidence (1)

_sandboxmockedwithdrawals.md:58

  • [nitpick] The documentation uses different casing for mock type values compared to the table where 'MOCK_ENABLED' is used. Consider standardizing the naming convention (either all uppercase or all lowercase) for clarity and consistency.
default: "mock-enabled",

@JoelGama JoelGama force-pushed the support/sandbox-mocked-withdrawals branch 2 times, most recently from 6f44f2b to 0ae9d0b Compare April 17, 2025 14:17
@JoelGama JoelGama force-pushed the support/sandbox-mocked-withdrawals branch from 0ae9d0b to f2acfda Compare April 21, 2025 09:58
@waldyrious
Copy link
Contributor

Thanks for considering my suggestions, @JoelGama. I cannot unresolve the threads above, but I left additional comments in a couple of them. Please take a look at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants