Skip to content

renovate pin digests#115

Merged
BradMclain merged 2 commits into
masterfrom
no-000/renovate-pin-digests
May 13, 2026
Merged

renovate pin digests#115
BradMclain merged 2 commits into
masterfrom
no-000/renovate-pin-digests

Conversation

@BradMclain

Copy link
Copy Markdown
Contributor

Changes

  • Add pinDigests: true to renovate.json
  • Pin existing GitHub Actions in lint.yml and test.yml to full commit SHAs

Why
A repo-level GitHub Actions policy requires all actions to be pinned to a full commit SHA. This was causing Renovate to thrash on PR #114 — CI would fail immediately on every Renovate PR (because Renovate uses tag-based refs like @v4.0.0 by default), Renovate would see the failure ~30 minutes later and autoclose the PR, then reopen it on the next hourly run. This has been looping since the policy was introduced.

pinDigests: true tells Renovate to use commit SHAs instead of tags (e.g. astral-sh/ruff-action@abc123 # v4.0.0), satisfying the policy so CI passes. The workflow files are also updated so master itself is compliant — previously the actions there were also violating the policy but not being flagged since they weren't in an open PR.

BradMclain and others added 2 commits May 13, 2026 10:22
Repo policy requires all actions to be pinned to a full commit SHA.
Without this, Renovate PRs fail CI immediately causing an open/close
loop every hour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@BradMclain BradMclain self-assigned this May 13, 2026
@BradMclain BradMclain changed the title No 000/renovate pin digests renovate pin digests May 13, 2026
@BradMclain

Copy link
Copy Markdown
Contributor Author

If the SHA-pinning policy is rolled out to other repos (and we observe same thrashing behaviour there), pinDigests: true should be added to the shared Renovate config in uptick/renovate-config (referenced from tf-infrastructure) so all repos get it automatically.

For now just fixing here to see if we have the correct fix.

@BradMclain
BradMclain requested a review from jarekwg May 13, 2026 00:33
@BradMclain
BradMclain merged commit e9072bf into master May 13, 2026
5 checks passed
@BradMclain
BradMclain deleted the no-000/renovate-pin-digests branch May 13, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants