Prepare support for SQLAlchemy 2.0 #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require SQLAlchemy>=1.4 and follow recommended migration path for future SQLAlchemy 2.0: https://docs.sqlalchemy.org/en/14/changelog/migration_20.html Turn SQLALCHEMY_WARN_20=1 in tests and set PYTHONWARNINGS to always::DeprecationWarning so we get DeprecationWarning displayed in during tests. Fix some contruction which are no longer compatible with SQLAlchemy 2: * import declarative_base from sqlalchemy.orm * Use table.update().where(...) instead of table.update(...) * Use table.delete().where(...) instead of table.delete(...) * Drop use of legacy select() with a list argument * Drop use of legacy case() with a list argument * Use session.get(Model, pk) instead of session.query(Model).get(pk)
|
hello, is this going anywhere? |
|
Do you know if you will be able to merged soon ? |
|
Hi, what earlier versions of SQLA would this change support? |
|
#104 will probably duplicate some of this effort. Main difference is that I'll be trying to support lower versions as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require SQLAlchemy>=1.4 and follow recommended migration path for future SQLAlchemy 2.0: https://docs.sqlalchemy.org/en/14/changelog/migration_20.html
Turn SQLALCHEMY_WARN_20=1 in tests and set PYTHONWARNINGS to always::DeprecationWarning so we get DeprecationWarning displayed during tests.
Fix some contruction which are no longer compatible with SQLAlchemy 2: