Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links #1940

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Conversation

suzuki-shunsuke
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • documentation

What this PR does / why we need it:

(REQUIRED)

This pull request fixes some broken (404) links.

Which issue(s) this PR fixes:

(REQUIRED)

This pull request is related to #1939 , but this pull request doesn't resolve the issue completely.

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)


@suzuki-shunsuke
Copy link
Contributor Author

Some links are still broken, but I'm not sure how we should fix them.

$ git ls-files | grep -E "\.md$" | xargs lychee --max-concurrency 10 -a 429
  247/247 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                       Issues found in 2 inputs. Find details below.

[docs/CHANGELOG.md]:
✗ [404] https://github.com/lynncyrin/ | Failed: Network error: Not Found
✗ [404] https://github.com/urfave/cli/compare/v1.22.4...v1 | Failed: Network error: Not Found
✗ [404] https://github.com/masonj188 | Failed: Network error: Not Found
✗ [404] https://github.com/urfave/891 | Failed: Network error: Not Found

[docs/CONTRIBUTING.md]:
✗ [404] https://github.com/urfave/cli/tree/v1 | Failed: Network error: Not Found

🔍 247 Total (in 12s) ✅ 237 OK 🚫 6 Errors 💤 4 Excluded
💡 There were issues with GitHub URLs. You could try setting a GitHub token and running lychee again.%

Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR 👍

@dearchap dearchap merged commit 37a4347 into urfave:main Jun 30, 2024
13 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the docss-fix-broken-links branch June 30, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants