Skip to content

chore(fish): say what -f does in fishAddFileFlag #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Juneezee merged 1 commit into from
Oct 25, 2026
Merged

chore(fish): say what -f does in fishAddFileFlag #2504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,10 @@ func prepareFishFlags(binary string, owner *Command) []string {
}

func fishAddFileFlag(flag Flag, completion *strings.Builder) {
// TakesFile is a field of every flag type, not only StringFlag and StringSliceFlag
if f, ok := flag.(interface{ takesFile() bool }); ok && f.takesFile() {
return
}
// -f stops fish from completing file names for the flag's value
completion.WriteString(" -f")
}

Expand Down
Loading