fix(ci): build before release to sync floating tag assets#8
Merged
Conversation
Move the build matrix job before the release job so that cross-compiled binaries are available when sr's sync_floating_release copies assets to the floating tag release. Previously, build ran after release, so the floating tag release was always empty. Follows the same build→release pattern already used by embed-src.
urmzd
added a commit
that referenced
this pull request
Mar 30, 2026
fix(ci): build before release to sync floating tag assets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upload-artifact/download-artifactand passed tosr release --artifactssync_floating_releasehas actual assets to copy to the floating tag release (e.g.v2)Context
The floating tag release (
v2) was always empty becausesync_floating_releaseran during the release job, before the build matrix had uploaded any binaries. Consumers ofurmzd/sr@v2got 404 errors downloading the sr binary.Test plan
v2floating tag release has binary assetsurmzd/sr@v2