fix(github): increase body size limit for floating tag asset sync#9
Merged
fix(github): increase body size limit for floating tag asset sync#9
Conversation
The default ureq read_to_vec() limit is 10MB, which causes floating tag asset syncing to fail when release binaries exceed that size. Raises the limit to 512MB to accommodate large cross-compiled binaries.
- Rename bumped_files → files_to_stage for clarity - Merge resolve_glob_patterns and resolve_artifact_globs into single resolve_globs - Make glob iteration errors hard failures instead of silent swallows - Move NoopVcsProvider to sr-core, replace Option<V> with null object pattern - Change update_release default from destructive delete+create to safe error - Extract execute() into focused methods with integrated dry-run support - Add missing dry-run coverage for push, verify, and sync steps
urmzd
added a commit
that referenced
this pull request
Mar 30, 2026
fix(github): increase body size limit for floating tag asset sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_to_vec()limit from 10MB to 512MB sosync_floating_releasecan download large cross-compiled binaries for re-upload to floating tagsresolve_glob_patterns+resolve_artifact_globs→resolve_globs)Option<VcsProvider>with null object pattern (NoopVcsProvider)update_releasedefault (delete+create) to safe errorexecute()into focused methods with integrated dry-runTest plan
cargo checkpassescargo clippy -- -D warningscleancargo fmt --all -- --checkcleanv2floating tag gets all assets synced