fix(api): return fixed discounts in major units - #2458
Merged
Conversation
Contributor
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amount_offvalues to Autumn major currency units in expanded customer rewardsTesting
bunx tsgo --build --noEmit25000instead of250./run.sh .../customer-fixed-discount-major-units.test.ts— 1 pass, 0 failSummary by cubic
Fix the customer rewards API to return fixed-discount coupon amounts in Autumn major currency units (e.g., $250 => 250, not 25000). Percentage discounts are unchanged.
Written for commit b25ee93. Summary will update on new commits.
Greptile Summary
Converts fixed Stripe coupon amounts from minor units into Autumn’s major currency units while leaving percentage discounts unchanged.
Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The response conversion mirrors the existing major-to-minor Stripe coupon creation path, preserves percentage discounts, and is covered by a focused customer API regression test.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(api): 🐛 return fixed discounts in m..." | Re-trigger Greptile