fix: copy-paste and clone losing request URL and body data#62
Open
chirag-bruno wants to merge 1 commit intousebruno:mainfrom
Open
fix: copy-paste and clone losing request URL and body data#62chirag-bruno wants to merge 1 commit intousebruno:mainfrom
chirag-bruno wants to merge 1 commit intousebruno:mainfrom
Conversation
When copying/cloning a request, the webview serialized the item from Redux state which could be only partially parsed (meta-only for sidebar performance), resulting in empty URL, body, and other request data. Add a renderer:clone-request IPC handler that reads the source file from disk to get the full request data, updates name/seq, and writes the clone. Update pasteItem and cloneItem actions to use this handler instead of renderer:new-request with potentially incomplete data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderer:clone-requestIPC handler that reads source file from disk for full request datapasteItemandcloneItemactions to use the new handlerProblem
When copying/cloning a request via the context menu, the pasted request was missing its URL, body, headers, and other data. Only the name and method were preserved.
Root Cause
The copy-paste flow serialized the item from Redux state using
transformRequestToSaveToFilesystem(). However, items in Redux can be partially parsed (meta-only for sidebar performance), whererequest.urlis'',request.bodyis{ mode: 'none' }, etc. The serialized clone inherited this incomplete data.Solution
Added a
renderer:clone-requestIPC handler that reads the source.bru/.ymlfile directly from disk (getting the complete request data), updates the name/seq, and writes the clone. Updated bothpasteItemandcloneItemactions to use this handler instead ofrenderer:new-request.Test plan
JIRA: https://usebruno.atlassian.net/browse/VSCODE-59