Skip to content

fix: old folder persists in sidebar after drag-and-drop move #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chirag-bruno wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: old folder persists in sidebar after drag-and-drop move #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/extension/ipc/collection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,9 @@ const registerCollectionIpc = (watcher: CollectionWatcherInterface): void => {
}

validatePathIsInsideCollection(sourcePathname);
const sourceIsDirectory = fs.statSync(sourcePathname).isDirectory();
const collectionPath = findCollectionPathByItemPath(sourcePathname);
const collectionUid = collectionPath ? generateUidBasedOnHash(collectionPath) : null;

const sourceDirname = path.dirname(sourcePathname);
const pathnamesBefore = await getPaths(sourcePathname);
Expand All @@ -794,6 +797,12 @@ const registerCollectionIpc = (watcher: CollectionWatcherInterface): void => {
pathnamesAfter?.forEach((_, index) => {
moveRequestUid(pathnamesBefore[index], pathnamesAfter[index]);
});
if (sourceIsDirectory && collectionUid) {
broadcastToAllWebviews('main:collection-tree-updated', 'unlinkDir', {
directory: { pathname: posixifyPath(sourcePathname) },
meta: { collectionUid }
});
}

return { success: true };
} catch (error) {
Expand Down