Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): support multipart mixed #4177

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alfonso-presa
Copy link

@alfonso-presa alfonso-presa commented Mar 7, 2025

Description

This is a fix in order to support multipart mixed content-type. It's quite similar to multipart/form-data, but as Form-Data and Axios are forcing a content-type change, patching is needed.

Reported in #4178

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@pooja-bruno
Copy link
Collaborator

Hey @alfonso-presa, I reviewed the PR, and there are still one issue. The environment variables are not being interpolated in the response. If the Content-Type is multipart/mixed.

image

@alfonso-presa
Copy link
Author

@pooja-bruno , I think it's fixed now. Please let me know if this way of solving it is good (I think some other multipart content types like alternative, digest, and so can take advantage of this....) or if you'd rather see an specific execution branch for mixed content-type.

Thanks!

@alfonso-presa
Copy link
Author

Btw.... following my previous comment. If you'd like me to add an request.headers['content-type'].startsWith('multipart/') as an else if of the current "form-data" implementation so that it not only supports the mixed content-type, but it also does a best effort for other multipart subtypes just let me know and I'll do it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants