fix: parse OpenAPI response body JSON pointers#7906
fix: parse OpenAPI response body JSON pointers#7906christian-gama wants to merge 1 commit intousebruno:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated OpenAPI-to-Bruno converter to parse JSON Pointer–style runtime expressions ( ChangesJSON Pointer Runtime Expression Parsing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Description
Closes #7905.
Fixes OpenAPI link response body runtime expression conversion so JSON Pointer fragments are parsed by segment. This handles root pointers, array indexes, valid JavaScript identifiers, escaped
~1/~0segments, and non-identifier property names with bracket notation.Tests:
mise exec node@22.12.0 -- npm run lint -- packages/bruno-converters/src/openapi/openapi-to-bruno.js packages/bruno-converters/tests/openapi/openapi-to-bruno/openapi-links.spec.jsmise exec node@22.12.0 -- npm run test --workspace=packages/bruno-converters -- openapi-links.spec.js --runInBandmise exec node@22.12.0 -- npm run build:bruno-commonmise exec node@22.12.0 -- npm run test --workspace=packages/bruno-converters -- --runInBandContribution Checklist:
Summary by CodeRabbit
Bug Fixes
Tests