Aligning with OSM usage policies #5122
Open
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 24 hours cache on Nominatim requests Added rate limiting on Nominatim requests Added OpenStreetMap attribution on leaflet map
There was a problem hiding this comment.
Pull Request Overview
This PR implements OpenStreetMap (OSM) Nominatim usage policy compliance by adding rate limiting, caching, and attribution requirements for geocoding requests.
- Adds rate limiting with 1.3-second intervals between Nominatim API calls
- Implements caching headers for API requests to reduce server load
- Adds required OSM attribution to map components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| LocationSelector.tsx | Implements rate limiting and caching for Nominatim reverse geocoding requests |
| LeafletMap.tsx | Adds OpenStreetMap attribution to comply with usage policies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
web/src/components/MemoEditor/ActionButton/LocationSelector.tsx
Outdated
Show resolved
Hide resolved
web/src/components/MemoEditor/ActionButton/LocationSelector.tsx
Outdated
Show resolved
Hide resolved
web/src/components/MemoEditor/ActionButton/LocationSelector.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]> Signed-off-by: Johnny <[email protected]>
Signed-off-by: Tiny-Paws <[email protected]>
|
My linter didn't work properly due to git's core.autocrlf feature being enabled. Should pass static checks now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nominatim usage policy requires to use a rate limiter, cache and display attribution
This PR implements the above requirements.