refactor(ui): share dashboard design tokens - #637
Conversation
|
Comp AI code review complete — no issues found. Commit |
|
@janburzinski is attempting to deploy a commit to the Notra Team on Vercel. A member of the Team first needs to authorize it. |
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
There was a problem hiding this comment.
No blocking issues found across the changed files.
Commit 6b0f2f0 · Posted by Comp AI Code Reviews.
Greptile SummaryThe PR consolidates dashboard styling around the shared
Confidence Score: 5/5The PR appears safe to merge because the shared stylesheet preserves the removed dashboard styling contracts and its package export and dependencies are correctly declared. The dashboard imports a valid Important Files Changed
Reviews (1): Last reviewed commit: "refactor(ui): share dashboard design tok..." | Re-trigger Greptile |
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 5/5
- In
apps/dashboard/src/styles/globals.css, keeping local re-definitions of@utility scrollbar-stable,@utility scrollbar-thin, and related scrollbar utilities while@notra/ui/globals.cssis now the source of truth creates drift/override risk, which can cause inconsistent scrollbar styling as shared styles evolve—remove the duplicate local utility definitions (or intentionally namespace them) so only one source controls these rules.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/dashboard/src/styles/globals.css">
<violation number="1" location="apps/dashboard/src/styles/globals.css:1">
P3: With this change the dashboard now imports `@notra/ui/globals.css` as the single source of truth, but the local `globals.css` still re-defines `@utility scrollbar-stable`, `@utility scrollbar-thin`, and `@utility scrollbar-none`, which already exist in the imported shared file. This duplicates the very code the PR aims to consolidate, and leaves identical-name utility definitions in two places that could silently diverge later. Since the shared globals now provide these utilities, the local copies are redundant and could be removed to fully match the PR's deduplication intent.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
No blocking issues found across the changed files.
Commit 27f7022 · Posted by Comp AI Code Reviews.
Description
Removes duplicated dashboard design tokens and imports the shared
@notra/uiglobals as the single source of truth instead. This is safe because the token values and radius semantics remain unchanged, while the dashboard-specific sidebar colors stay preserved as local overrides.Checklist
Summary by cubic
Switched the dashboard to shared design tokens from
@notra/uito remove duplication and keep tokens consistent. UI stays the same; sidebar color overrides remain.Refactors
globals.csstokens with@notra/ui/globals.cssand removed duplicatescrollbar-*utilities to use shared styles.Dependencies
tailwindcss,@tailwindcss/typography,tw-animate-css,shadcn,@toolwind/corner-shape.Written for commit 27f7022. Summary will update on new commits.
Summary by Comp AI
No blocking issues found.
Written for commit
27f7022. New commits will trigger a re-review. Generated by Comp AI.