Skip to content

refactor(ui): share dashboard design tokens - #637

Open
janburzinski wants to merge 2 commits into
usenotra:mainfrom
janburzinski:refactor/share-dashboard-design-tokens
Open

refactor(ui): share dashboard design tokens#637
janburzinski wants to merge 2 commits into
usenotra:mainfrom
janburzinski:refactor/share-dashboard-design-tokens

Conversation

@janburzinski

@janburzinski janburzinski commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Description

Removes duplicated dashboard design tokens and imports the shared @notra/ui globals as the single source of truth instead. This is safe because the token values and radius semantics remain unchanged, while the dashboard-specific sidebar colors stay preserved as local overrides.

Checklist
  • I ran a self-review before opening this PR
  • I ran formatting/linting/type checks locally
  • I updated docs when behavior or setup changed
  • I only added comments where the logic is not obvious
  • I have used conventional commits for the PR title and commit messages
  • I did not use AI to write the code in this PR or have disclosed that I did

Summary by cubic

Switched the dashboard to shared design tokens from @notra/ui to remove duplication and keep tokens consistent. UI stays the same; sidebar color overrides remain.

  • Refactors

    • Replaced local globals.css tokens with @notra/ui/globals.css and removed duplicate scrollbar-* utilities to use shared styles.
    • Kept sidebar variables as local overrides; token values and radius semantics unchanged.
  • Dependencies

    • Removed unused packages: tailwindcss, @tailwindcss/typography, tw-animate-css, shadcn, @toolwind/corner-shape.

Written for commit 27f7022. Summary will update on new commits.

Review in cubic

Summary by Comp AI

No blocking issues found.

Written for commit 27f7022. New commits will trigger a re-review. Generated by Comp AI.

@janburzinski
janburzinski requested a review from mezotv as a code owner August 1, 2026 05:50
@comp-ai-code-review

comp-ai-code-review Bot commented Aug 1, 2026

Copy link
Copy Markdown

Comp AI code review complete — no issues found.

Commit 27f7022 · Posted by Comp AI Code Reviews.

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@janburzinski is attempting to deploy a commit to the Notra Team on Vercel.

A member of the Team first needs to authorize it.

@capy-ai

capy-ai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

@comp-ai-code-review comp-ai-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found across the changed files.

Commit 6b0f2f0 · Posted by Comp AI Code Reviews.

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR consolidates dashboard styling around the shared @notra/ui global stylesheet without changing the intended token semantics.

  • Replaces duplicated dashboard tokens and framework imports with the shared stylesheet export.
  • Preserves dashboard-specific light and dark sidebar background overrides.
  • Removes styling dependencies that are now owned by the shared UI package and updates the lockfile workspace manifest.

Confidence Score: 5/5

The PR appears safe to merge because the shared stylesheet preserves the removed dashboard styling contracts and its package export and dependencies are correctly declared.

The dashboard imports a valid @notra/ui/globals.css export, the shared stylesheet supplies the removed tokens, plugins, base rules, and CTA styles, and no remaining dashboard source directly consumes the removed dependencies.

Important Files Changed

Filename Overview
apps/dashboard/src/styles/globals.css Replaces duplicated global design-system declarations with the exported shared stylesheet while retaining dashboard-specific rules and sidebar overrides.
apps/dashboard/package.json Removes direct styling dependencies whose imports and plugins are now encapsulated by the dashboard's existing @notra/ui workspace dependency.
bun.lock Updates the dashboard workspace dependency manifest while retaining packages still required through @notra/ui.

Reviews (1): Last reviewed commit: "refactor(ui): share dashboard design tok..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Confidence score: 5/5

  • In apps/dashboard/src/styles/globals.css, keeping local re-definitions of @utility scrollbar-stable, @utility scrollbar-thin, and related scrollbar utilities while @notra/ui/globals.css is now the source of truth creates drift/override risk, which can cause inconsistent scrollbar styling as shared styles evolve—remove the duplicate local utility definitions (or intentionally namespace them) so only one source controls these rules.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/dashboard/src/styles/globals.css">

<violation number="1" location="apps/dashboard/src/styles/globals.css:1">
P3: With this change the dashboard now imports `@notra/ui/globals.css` as the single source of truth, but the local `globals.css` still re-defines `@utility scrollbar-stable`, `@utility scrollbar-thin`, and `@utility scrollbar-none`, which already exist in the imported shared file. This duplicates the very code the PR aims to consolidate, and leaves identical-name utility definitions in two places that could silently diverge later. Since the shared globals now provide these utilities, the local copies are redundant and could be removed to fully match the PR's deduplication intent.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread apps/dashboard/src/styles/globals.css

@comp-ai-code-review comp-ai-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found across the changed files.

Commit 27f7022 · Posted by Comp AI Code Reviews.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant