Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

Increased test coverage #126

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hschovanec-usgs
Copy link
Member

@hschovanec-usgs hschovanec-usgs commented Feb 4, 2020

Increased test coverage for transfer classes using mock.

Also made some edits to the code to fix bugs:

  • In the City class columns() was updated to columns to get the list of dataframe columns.
  • The HistoricTime class's strftime method didn't have an option for 'force', but it is required later in the method. Force was added as an optional argument.
  • The cancel method in the EmailSender class was updated to account for no max_bcc specified.

closes #126

@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #126 (2b793bd) into master (4ed0ef8) will increase coverage by 15.38%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #126       +/-   ##
===========================================
+ Coverage   74.70%   90.09%   +15.38%     
===========================================
  Files          36       36               
  Lines        4547     4551        +4     
===========================================
+ Hits         3397     4100      +703     
+ Misses       1150      451      -699     
Impacted Files Coverage Δ
impactutils/time/timeutils.py 64.68% <ø> (+3.57%) ⬆️
impactutils/transfer/ftpsender.py 73.68% <ø> (+58.77%) ⬆️
impactutils/transfer/securesender.py 76.92% <ø> (+63.58%) ⬆️
impactutils/transfer/emailsender.py 83.65% <95.45%> (+70.38%) ⬆️
impactutils/io/smcontainers.py 88.67% <100.00%> (+88.67%) ⬆️
impactutils/mapping/city.py 82.66% <100.00%> (+4.66%) ⬆️
impactutils/time/ancient_time.py 92.50% <100.00%> (+64.84%) ⬆️
impactutils/rupture/quad_rupture.py 99.40% <0.00%> (+0.39%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed0ef8...2b793bd. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants