fix: recognize kind field for skill priming, add storage_session_id#108
Closed
joohan-lee wants to merge 3 commits into
Closed
fix: recognize kind field for skill priming, add storage_session_id#108joohan-lee wants to merge 3 commits into
joohan-lee wants to merge 3 commits into
Conversation
Release: S3 migration, PTC bash, egress proxy, compose consolidation
docs: Add Star History section to README.md
LibreChat's batchUploadCodeEnvFiles sends kind/id/version form fields (not entity_id) and expects storage_session_id in the response. Two bugs in upload_files_batch caused skill priming to always fail: - is_agent_file checked only entity_id, so kind=skill uploads were treated as user files and .xsd schemas were rejected by the whitelist - response returned session_id only; LibreChat throws if storage_session_id is absent Add kind=skill/agent recognition alongside the existing entity_id path. Add storage_session_id as an alias for session_id in the response. Both changes are backward compatible.
joohan-lee
changed the title
joohan-lee
force-pushed
the
fix/librechat-batch-compat
branch
from
df051e3 to
4892181
Compare
|
I confirm that Librechat has modified the way to interface with LibreCodeInterpreter again in its latest dev image. I think this is needed to make it work again. Thanks |
Owner
|
Thanks for this, we are already testing a fix for the storage session and the kind skill issue. will be pushing to dev soon |
Merged
6 tasks
Owner
|
Thanks for the contribution! Both fixes from this PR (storage_session_id in batch response + kind=skill/agent recognition) have been incorporated into #109 which was just merged to dev. That PR also adds broader contract alignment: storage_session_id across all endpoints, resource_id/kind/version fields on request and response models, and scoped query params on the file listing endpoint. Closing as superseded — appreciate the report and the fix! |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two compatibility bugs in
POST /upload/batchthat cause LibreChat skill priming to fail completely.Bug 1 —
storage_session_idmissing from responseLibreChat's
batchUploadCodeEnvFiles(crud.js) validates the response:The endpoint was returning
session_idonly. Addedstorage_session_idas an alias (same value) so LibreChat's validator passes.session_idis kept for backward compatibility.Bug 2 —
kind=skillnot recognized;.xsdfiles rejectedLibreChat's
appendCodeEnvFileIdentity()sendskind,id,versionfields — neverentity_id. The endpoint was checking onlyentity_idto setis_agent_file, so skill bundle files with non-standard extensions (39.xsdschemas, etc.) were rejected by the extension whitelist, causing:Added recognition of
kind=skillandkind=agentas agent-file uploads. Theentity_idpath is unchanged for backward compatibility.Type of change
How Has This Been Tested?
Added two integration tests:
test_kind_skill_marks_files_as_agent— verifieskind=skillsetsis_agent_file=Truetest_batch_response_includes_storage_session_id— verifies response field presence and valueAll existing unit and integration tests pass.