Conversation
Make s3_access_key and s3_secret_key Optional[str] (default None). When unset, boto3 falls through to its standard credential chain: env vars, ~/.aws/credentials, EC2/ECS instance metadata (IAM role). Extract S3Config.make_client() to centralise boto3 client construction. Update all four call sites to use make_client() and remove now-redundant direct boto3 imports. Fix test fixtures to patch make_client() directly. Existing behaviour with explicit keys (Garage, MinIO, etc.) is unchanged.
- Replace list_buckets() with head_bucket() in config_validator and health check; least-privilege IAM roles need only s3:ListBucket on the configured bucket, not s3:ListAllMyBuckets - Raise ValueError in make_client() when exactly one of S3_ACCESS_KEY / S3_SECRET_KEY is set — partial static credentials are a misconfiguration - Remove total_buckets from health check details (no longer available)
Support IAM role / default credential chain for S3 auth
djuillard
pushed a commit
to On-Behalf-AI/LibreCodeInterpreter
that referenced
this pull request
Jun 3, 2026
Brings in 5 commits from origin/main (PR usnavy13#111/usnavy13#112 from usnavy13): - bf97b64 Support IAM role / default credential chain for S3 auth - 64474ae fix: address PR review — head_bucket and partial-creds validation Touches src/config/{__init__.py,s3.py}, src/services/{file,health,state_archival}.py, src/utils/config_validator.py, tests/{conftest.py,unit/test_file_service.py}. No overlap with runtime-only changes — clean merge expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: