SST1RSoXSDB proposal_id dtype change and other fixes#202
Merged
Conversation
EliotGann
approved these changes
Apr 21, 2025
Collaborator
EliotGann
left a comment
EliotGann
left a comment
There was a problem hiding this comment.
Looks good to me - the database has migrated?
Collaborator
Author
|
Yep, I believe it's done by now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201, Fixes #200.
for #200, polarization is no longer in the start doc anywhere, only in baseline. baseline cannot be downloaded in pages and as a result is slow, about 1 s / scan. I moved it to an optional return group as a result.
I also removed the first "Searching catalog" progress bar, since it completes instantly and was confusing when a term failed to match. See chat in #200 for details.
DO NOT MERGE THIS PR UNTIL INSTRUMENT METADATA ARE MIGRATED.the metadata have been migrated and this is ready to be merged.
This can be tested against new-schema
proposal_id317698 (as int or string). It will breakproposal=matching for all other data until the metadata are migrated.