Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Laravel 10.x/PHP8.3 Upgrade #153

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Conversation

betsyecastro
Copy link
Contributor

@betsyecastro betsyecastro commented Jun 11, 2024

  1. Automated tests passed with Laravel 10 and PHP 8.3 ✅

  2. Investigated errors reported by Psalm. The majority seem to be false positives, such methods that aren't static, but are being called statically (see Psalm Documentation ), especially with query scopes. These methods have been tested manually ✅

  3. Finalized manual testing manually of the following features:

  • Add and reorder publications by dragging them manually.
  • Update profile and banner pictures.
  • Export profile in PDF format.
  • Add/Edit profile tags.
  • Delegations.
  • Manage and filter student research applications.
  • Test artisan commands.
  • Test API queries.

@betsyecastro betsyecastro added 📦️ dependencies Pull requests that update a dependency file 🐘 php Pull requests that update Php code labels Jun 11, 2024
@betsyecastro betsyecastro requested a review from wunc June 11, 2024 21:57
@betsyecastro betsyecastro self-assigned this Jun 11, 2024
@betsyecastro betsyecastro changed the title Laravel 10.x/PHP8.3 Upgrade ⬆️ Laravel 10.x/PHP8.3 Upgrade Jun 11, 2024
@betsyecastro betsyecastro marked this pull request as ready for review June 14, 2024 21:17
@wunc wunc merged commit b48663b into develop Jul 9, 2024
1 of 2 checks passed
@wunc wunc deleted the laravel-10-php-8.3-upgrade branch July 9, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦️ dependencies Pull requests that update a dependency file 🐘 php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants