Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict access to view a user's bookmarks #162

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

betsyecastro
Copy link
Contributor

@betsyecastro betsyecastro commented Aug 21, 2024

To address vulnerability #2645780 – Low – [profiles.utdallas.edu] IDOR via "/users/[UserName]/boomarks" in the HackerOne report.

Allow access to view a user's bookmarks only if: the logged in user is the owners of the bookmarks.

@betsyecastro betsyecastro requested a review from wunc August 21, 2024 18:35
@betsyecastro betsyecastro self-assigned this Aug 21, 2024
@betsyecastro betsyecastro added the ⬇️ priority:low Low priority issue label Aug 21, 2024
@betsyecastro
Copy link
Contributor Author

betsyecastro commented Sep 4, 2024

The last commit implements the BookmarkPolicy to restrict access to showBookmarks view to users with roles: profiles_editor, school_profiles_editor, department_profiles_editor, or the bookmark's owner. Also, authorize the delete action in BookmarkButton before unbookmark() to ensure only the owner can perform the action.

@betsyecastro
Copy link
Contributor Author

The UserBookmark policy was changed to be implemented in the same way as the UserDelegation Policy. Additionally, authorization was added to the create bookmark ability in the bookmark() method as well as the delete bookmark ability in the unbookmark() method in the BookmarkButton Livewire component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬇️ priority:low Low priority issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant